From 0982d4d07818a11f006966e56e8ff92d7a6dd80e Mon Sep 17 00:00:00 2001
From: albertlast <mathiaspapealbert@hotmail.com>
Date: Sat, 8 Aug 2026 18:46:44 +0200
Subject: [PATCH] Makes the report picker a list of labelled choices

template_report_type() built its list of reports as a dl.settings, which is
the label-and-control pattern used for settings forms. It does not fit here:
the <dt> held the report's description rather than its label, and the <dd>
held the radio together with the label it belongs to. So the definition list
paired every report's description with the report after it, and the actual
label was inside the definition rather than the term.

Each report is now one <label> wrapping its radio, title and description,
which is the shape template_maintain_options() already uses for the forum
maintenance picker, and the .option_form rules that came with it lay this
out with no new CSS.

The form still posts, and still carries the session token.

Signed-off-by: Mathias Papenbrock <mathiaspapealbert@hotmail.com>
Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
---
 Themes/default/Reports.template.php | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/Themes/default/Reports.template.php b/Themes/default/Reports.template.php
index d8271bd612b..84eca1f704e 100644
--- a/Themes/default/Reports.template.php
+++ b/Themes/default/Reports.template.php
@@ -22,31 +22,30 @@
 function template_report_type()
 {
 	echo '
-		<form action="', Config::$scripturl, '?action=admin;area=reports" method="post" accept-charset="UTF-8">
-			<div class="cat_bar">
-				<h3 class="catbg">', Lang::getTxt('generate_reports_type', file: 'Reports'), '</h3>
-			</div>
-			<div class="windowbg">
-				<dl class="settings">';
+		<div class="cat_bar">
+			<h3 class="catbg">', Lang::getTxt('generate_reports_type', file: 'Reports'), '</h3>
+		</div>
+		<form action="', Config::$scripturl, '?action=admin;area=reports" method="post" accept-charset="UTF-8" class="windowbg option_form">';
 
 	// Go through each type of report they can run.
 	foreach (Utils::$context['report_types'] as $type) {
+		echo '
+			<label>
+				<input type="radio" name="rt" value="', $type['id'], '"', $type['is_first'] ? ' checked' : '', '>
+				<strong>', $type['title'], '</strong>';
+
 		if (isset($type['description'])) {
 			echo '
-					<dt>', $type['description'], '</dt>';
+				<p>', $type['description'], '</p>';
 		}
 
 		echo '
-					<dd>
-						<input type="radio" id="rt_', $type['id'], '" name="rt" value="', $type['id'], '"', $type['is_first'] ? ' checked' : '', '>
-						<strong><label for="rt_', $type['id'], '">', $type['title'], '</label></strong>
-					</dd>';
+			</label>';
 	}
+
 	echo '
-				</dl>
-				<input type="submit" name="continue" value="', Lang::getTxt('generate_reports_continue', file: 'Reports'), '" class="button">
-				<input type="hidden" name="', Utils::$context['session_var'], '" value="', Utils::$context['session_id'], '">
-			</div><!-- .windowbg -->
+			<input type="submit" name="continue" value="', Lang::getTxt('generate_reports_continue', file: 'Reports'), '" class="button">
+			<input type="hidden" name="', Utils::$context['session_var'], '" value="', Utils::$context['session_id'], '">
 		</form>';
 }