Repository navigation
Fix values from a FixValueFeedforward between solves - #1694
Merged
Merged
Conversation
jd-lara
self-requested a review
October 10, 2026 23:20
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a simulation without rebuilds, a model is built for recurrent solves, so its parameter arrays hold JuMP variables.
Updating a
FixValueFeedforwardparameter then had no_fix_parameter_value!method for that array type, and the simulation failed at its second step with aMethodError.The parameter update already fixes each parameter variable to its state value, and the
FeedforwardFixValueConstraintrows built with the model tie the affected variables to them, so the new method has nothing further to do.Testing
Adds a two-stage UC→ED testset to
test_simulation_execute.jl, run with the in-memory and HDF stores, that fixes the ED'sOnVariableto the UC's.It checks that every ED commitment equals the UC commitment of the hour it falls in.
Before the fix the simulation fails with the
MethodError; after it, every test in the file passes (with #1690 and #1691 applied).🤖 Generated with Claude Code