Repository navigation
Forward-merge release/26.12 into main - #25300
Merged
Merged
Conversation
…4947) Fix floating-point Python-style modulo (`PyMod`) returning `NaN` for positive infinite divisors (#24898) and returning zero for large negative divisors (#24895). Previously, `fmod(fmod(x, y) + y, y)` was used. For infinite divisors, `fmod(x, inf)` returned `x`, but `x + inf` became `inf`, leading to `fmod(inf, inf) = NaN`. For large finite negative divisors like `-1e18`, float precision limits caused `fmod(x, y) + y` to round to `y`, resulting in `fmod(y, y) = -0.0`. This aligns floating-point `PyMod` across operator templates and test utilities with Python/NumPy semantics: compute `fmod(x, y)`, adjust when signs differ (`mod += y`), and preserve the divisor sign on zero with `copysign`. Added C++ unit tests in `operator_parity_test.cpp` and Python tests in `test_binops.py`. Closes #24898 Closes #24895 Authors: - Sai krishna Bodapati (https://github.com/bodapatisaikrishna) - Muhammad Haseeb (https://github.com/mhaseeb123) - Bradley Dice (https://github.com/bdice) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Lawrence Mitchell (https://github.com/wence-) URL: #24947
Contributor
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
libcudf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.12 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.