Optimize tensor indexing for ranks 1-4 with explicit stride calculations - #1057
Merged
Merged
Conversation
Replace recursive GetValC template instantiation with GetOffsetOptimized that provides explicit constexpr branches for tensor ranks 1-4. This allows the compiler to better optimize stride calculations by making all multiplications visible at compile time. Changes: - Add GetOffsetOptimized() with unrolled stride calculations for ranks 1-4 - Use cuda::std::array for index storage instead of tuple operations - Update operator() and GetPointer() to use the optimized function - Fall back to recursive GetValC only for tensors with rank > 4 This addresses compiler optimization issues where GetValC's recursive template instantiation prevented effective optimization of the common case tensor operations.
Collaborator
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace recursive GetValC template instantiation with GetOffsetOptimized that provides explicit constexpr branches for tensor ranks 1-4. This allows the compiler to better optimize stride calculations by making all multiplications visible at compile time.
Changes:
This addresses compiler optimization issues where GetValC's recursive template instantiation prevented effective optimization of the common case tensor operations.