Explain format rejections; reseed name on audio toggle

Author: houssemko

po/grab.pot

@@ -981,3 +981,23 @@ msgstr ""
 #: src/preferences.rs:649
 msgid "Couldn't check for updates"
 msgstr ""
+
+#: src/video.rs:340
+msgid "No suitable formats found for this media ({total} listed: {reasons})"
+msgstr ""
+
+#: src/video.rs:330
+msgid "manifest"
+msgstr ""
+
+#: src/video.rs:331
+msgid "DRM"
+msgstr ""
+
+#: src/video.rs:332
+msgid "no link"
+msgstr ""
+
+#: src/video.rs:333
+msgid "video-only"
+msgstr ""

src/video.rs

@@ -292,6 +292,56 @@ impl VideoError {
     fn unavailable() -> Self {
         Self::Message(gettext("No suitable formats found for this media"))
     }
+    /// Same failure with a rejection census, so a page of manifest-only
+    /// variants (live/HLS pages) reads differently from a DRM or
+    /// link-less one instead of guessing.
+    fn unavailable_detail(formats: &[Format]) -> Self {
+        let total = formats.len();
+        if total == 0 {
+            return Self::Message(gettext(
+                "No suitable formats found for this media (the page listed none)",
+            ));
+        }
+        let (mut manifest, mut drm, mut no_link, mut video_only) = (0, 0, 0, 0);
+        for f in formats {
+            if f.protocol != Protocol::Https {
+                manifest += 1;
+            } else if matches!(f.has_drm, Some(DrmStatus::Yes)) {
+                drm += 1;
+            } else if f
+                .download_info
+                .url
+                .as_deref()
+                .filter(|u| !u.is_empty())
+                .is_none()
+            {
+                no_link += 1;
+            } else if f
+                .codec_info
+                .audio_codec
+                .as_deref()
+                .is_none_or(|c| c == "none")
+            {
+                video_only += 1;
+            }
+        }
+        let mut reasons = Vec::new();
+        for (n, label) in [
+            (manifest, gettext("manifest")),
+            (drm, gettext("DRM")),
+            (no_link, gettext("no link")),
+            (video_only, gettext("video-only")),
+        ] {
+            if n > 0 {
+                reasons.push(format!("{label}: {n}"));
+            }
+        }
+        Self::Message(
+            gettext("No suitable formats found for this media ({total} listed: {reasons})")
+                .replace("{total}", &total.to_string())
+                .replace("{reasons}", &reasons.join(", ")),
+        )
+    }
     fn part_failed(e: impl std::fmt::Display) -> Self {
         Self::Message(
             gettext("Media download failed: {detail}").replace("{detail}", &e.to_string()),
@@ -1570,7 +1620,7 @@ pub async fn run_video_download(
         }
     }
     let Some(audio_sel) = audio_sel else {
-        return Err(VideoError::unavailable());
+        return Err(VideoError::unavailable_detail(&video.formats));
     };
 
     tracing::info!(

src/video_tests.rs

@@ -1002,6 +1002,33 @@ fn video_format_options_lists_best_per_height() {
     assert_eq!(opts[1].label, "720p · av01 · 60.0 MB");
 }
 
+#[test]
+fn unavailable_detail_counts_rejections() {
+    let mut no_link = test_format_full("n", "avc1", "none", Some(720), None, "https", false);
+    no_link.as_object_mut().unwrap().remove("url");
+    let formats: Vec<yt_dlp::model::format::Format> = serde_json::from_value(serde_json::json!([
+        test_format_full("v", "avc1", "none", Some(720), None, "https", false),
+        test_format_full("h", "avc1", "none", Some(720), None, "m3u8_native", false),
+        test_format_full("d", "avc1", "none", Some(720), None, "https", true),
+        no_link,
+    ]))
+    .unwrap();
+    let message = match VideoError::unavailable_detail(&formats) {
+        VideoError::Message(m) => m,
+        other => panic!("expected message, got {other:?}"),
+    };
+    assert!(message.contains("4 listed"), "{message}");
+    assert!(message.contains("manifest: 1"), "{message}");
+    assert!(message.contains("DRM: 1"), "{message}");
+    assert!(message.contains("no link: 1"), "{message}");
+    assert!(message.contains("video-only: 1"), "{message}");
+    let empty = match VideoError::unavailable_detail(&[]) {
+        VideoError::Message(m) => m,
+        other => panic!("expected message, got {other:?}"),
+    };
+    assert!(empty.contains("listed none"), "{empty}");
+}
+
 #[test]
 fn codec_rank_orders_newest_first() {
     assert!(codec_rank("av01.0.08M.08") < codec_rank("vp9"));

src/window.rs

@@ -1798,6 +1798,24 @@ pub fn show_add_dialog(manager: Rc<DownloadManager>) {
             }
         });
     }
+    // Toggling the mode re-seeds an untouched name: the resolve-time
+    // seed ran under the other mode, so without this the row keeps a
+    // .mp4 name for an audio download (or vice versa). An edited name
+    // is never clobbered.
+    {
+        let (name, audio, info) = (step.name.clone(), step.audio.clone(), video_info.clone());
+        audio.connect_active_notify(move |sw| {
+            if let Some(v) = info.borrow().as_ref() {
+                let active = sw.is_active();
+                let current = name.text().to_string();
+                if current.trim().is_empty()
+                    || current == crate::video::default_video_filename(&v.title, !active)
+                {
+                    name.set_text(&crate::video::default_video_filename(&v.title, active));
+                }
+            }
+        });
+    }
 
     {
         let m = manager.clone();