Skip to content

etherparse - bulk adding more packet parsers? #143

Description

@randomizedcoder

@JulianSchmid

Thanks for your cool library.

I've been comparing different packet parses (linux kernel, libpcap, wireshark/tshark, scapy, etherparse), and finding which ones have the best parsing.

Full docs ( work in progress )
https://github.com/randomizedcoder/xdp2/tree/proto-audit/samples/proto_audit#proto-audit-cross-source-protocol-definition-audit

I'm then able to generate the packet parsers for the missing protocols.

For example, here are the patches generated for etherparse

https://github.com/randomizedcoder/xdp2/tree/proto-audit/samples/proto_audit/patches/etherparse

I think I'll actually be able to generate a LOT more, essentially bringing etherparse inline with libpcap & tshark ( tshark does like ~3k, so maybe not all those )

I noticed in the "issues" here, that people are asking for these protocols, so this would solve many of the "issues"

Question
How would you like the pull requests? Do you want one big one, or lots of smaller ones? Maybe one idea is a big pull request, with each parser as a commit?

Thanks in advance,
Dave

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions