Repository navigation
Various TTFX improvements - #3013
Open
JamesWrigley wants to merge 1 commit into
Open
JamesWrigley wants to merge 1 commit into
JamesWrigley wants to merge 1 commit into
Conversation
JamesWrigley
force-pushed
the
ttfx
branch
2 times, most recently
from
October 17, 2026 17:26
076c25c to
51ce4fc
Compare
- The autodocs sorting comparator previously called `string(x)` for every
comparison, which is quite expensive with many complex types. Now we convert
to strings once and cache them in a dict.
- `allbindings()` stored signatures in a `Set{Type}` which required hashing each
type, which required specializing hashing for each type, which is slow. Now we
use a `Vector{Type}` instead.
- Expanded the precompilation workload.
- Added some type-asserts/conversions to make the package more resistant to
invalidations.
Contributor
Author
|
(bump) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string(x)for every comparison, which is quite expensive with many complex types. Now we convert to strings once and cache them in a dict.allbindings()(used in the missing docs check) stored signatures in aSet{Type}, which required hashing each type, which required specializinghash()for each type, which is slow. Now we use aVector{Type}instead. For CImGui that almost entirely eliminated the ~7s of the missing docs check.Combined with JuliaDocs/DocStringExtensions.jl#309, this dropped the time to build the docs for CImGui.jl from ~38s to ~7s on my machine. Written with help from Claude 🤖