You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up from the architecture review of the feature/js-server-extensions branch (PR #687). Internal-only refactor — no exported package is affected (Export-Package lists only …engine.sdk), so this is non-breaking and can land anytime.
Move JSPromise from …engine.actions to …engine.jsengine. It is a general GraalJS facility (settling promises through microtask draining), not an actions concern; its current home would force unrelated features (see Retrofit async (promise) support to server extension-point callbacks #688) to import from actions.
Document the package layout rule in a package-info.java for …engine.registrars: single-class bridges live flat in registrars/; multi-class verticals get a subpackage (validation/, contentpatches/); non-registrar surfaces live outside (actions/ endpoint, sdk/ facade). The rule exists implicitly today, which makes the mixed layout look accidental to newcomers.
Acceptance.JSPromiseTest moved along with the class; mvn test green; package-info.java present with the rule stated in 3–4 sentences.
Follow-up from the architecture review of the
feature/js-server-extensionsbranch (PR #687). Internal-only refactor — no exported package is affected (Export-Packagelists only…engine.sdk), so this is non-breaking and can land anytime.JSPromisefrom…engine.actionsto…engine.jsengine. It is a general GraalJS facility (settling promises through microtask draining), not an actions concern; its current home would force unrelated features (see Retrofit async (promise) support to server extension-point callbacks #688) to import fromactions.package-info.javafor…engine.registrars: single-class bridges live flat inregistrars/; multi-class verticals get a subpackage (validation/,contentpatches/); non-registrar surfaces live outside (actions/endpoint,sdk/facade). The rule exists implicitly today, which makes the mixed layout look accidental to newcomers.Acceptance.
JSPromiseTestmoved along with the class;mvn testgreen;package-info.javapresent with the rule stated in 3–4 sentences.