Skip to content

Workflow comments are in French across the org #316

Description

@BryanFRD

The org writing rule is that everything is written in English, workflow comments explicitly included, with the sole exception of deliberately localised product copy. A chunk of the CI configuration does not follow it.

pr-title.yml, in 20 repositories. The file has been copied around with its comments in French. Same header everywhere:

# `pull_request_target` est délibéré et sûr ici : le job appelé ne fait aucun
# `checkout`, n'exécute donc rien qui vienne de la PR, et ne lit que le titre
# dans la charge utile de l'événement.

Benchmarks, Changelog, Docker-Runners, FerrAgents, FerrFlow, FerrFlow-Cloud, FerrGames-Cloud, FerrGames-Discord, FerrGrowth-Cloud, FerrLabs-Cloud, FerrLabs-Profile, FerrLens-Cloud, FerrTrack-Cloud, FerrVault-Cloud, Fixtures, Infra, Kit, MCP, Status, UI.

Four other files, each with its own French comments rather than a copy of that header:

  • FerrFlow-Cloud/.github/workflows/rebuild-site.yml
  • FerrLabs-Profile/.github/workflows/renovate.yml
  • FerrTrack-Cloud/.github/workflows/ci.yml
  • UI/.github/workflows/storybook-image.yml

The content is worth keeping. These are not decorative comments: the pull_request_target one explains why a normally dangerous trigger is safe here, the permissions: one explains that a called workflow can only narrow what the caller grants and that omitting the block produces a startup_failure with no check run at all, and FerrLabs-Profile's copy explains why the job is skipped rather than synchronize being dropped from the trigger. Translate them, do not delete them.

Two practical notes. pr-title.yml is 20 near-identical copies, so it is one translation applied 20 times rather than 20 pieces of work, and it is a candidate for the same reusable-workflow treatment the job inside it already gets. And since the copies have already drifted (FerrLabs-Profile's differs from the rest), translating is a good moment to check whether they should be converging instead.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions