Skip to content

Commit 2afccda

Browse files
committed
net/vmxnet3: remove unused queue dump functions
vmxnet3_rxq_dump() and vmxnet3_txq_dump() are guarded by RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED, a macro that is defined nowhere and whose name records that the callers were removed long ago. Building with the macro forced on only produces -Wunused-function warnings. Remove the dead code. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
1 parent 44b6f6f commit 2afccda

1 file changed

Lines changed: 0 additions & 58 deletions

File tree

drivers/net/vmxnet3/vmxnet3_rxtx.c

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -59,64 +59,6 @@
5959

6060
static int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t*, uint8_t);
6161
static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *);
62-
#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED
63-
static void vmxnet3_rxq_dump(struct vmxnet3_rx_queue *);
64-
static void vmxnet3_txq_dump(struct vmxnet3_tx_queue *);
65-
#endif
66-
67-
#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED
68-
static void
69-
vmxnet3_rxq_dump(struct vmxnet3_rx_queue *rxq)
70-
{
71-
uint32_t avail = 0;
72-
73-
if (rxq == NULL)
74-
return;
75-
76-
PMD_RX_LOG(DEBUG,
77-
"RXQ: cmd0 base : %p cmd1 base : %p comp ring base : %p.",
78-
rxq->cmd_ring[0].base, rxq->cmd_ring[1].base, rxq->comp_ring.base);
79-
PMD_RX_LOG(DEBUG,
80-
"RXQ: cmd0 basePA : 0x%lx cmd1 basePA : 0x%lx comp ring basePA : 0x%lx.",
81-
(unsigned long)rxq->cmd_ring[0].basePA,
82-
(unsigned long)rxq->cmd_ring[1].basePA,
83-
(unsigned long)rxq->comp_ring.basePA);
84-
85-
avail = vmxnet3_cmd_ring_desc_avail(&rxq->cmd_ring[0]);
86-
PMD_RX_LOG(DEBUG,
87-
"RXQ:cmd0: size=%u; free=%u; next2proc=%u; queued=%u",
88-
(uint32_t)rxq->cmd_ring[0].size, avail,
89-
rxq->comp_ring.next2proc,
90-
rxq->cmd_ring[0].size - avail);
91-
92-
avail = vmxnet3_cmd_ring_desc_avail(&rxq->cmd_ring[1]);
93-
PMD_RX_LOG(DEBUG, "RXQ:cmd1 size=%u; free=%u; next2proc=%u; queued=%u",
94-
(uint32_t)rxq->cmd_ring[1].size, avail, rxq->comp_ring.next2proc,
95-
rxq->cmd_ring[1].size - avail);
96-
97-
}
98-
99-
static void
100-
vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq)
101-
{
102-
uint32_t avail = 0;
103-
104-
if (txq == NULL)
105-
return;
106-
107-
PMD_TX_LOG(DEBUG, "TXQ: cmd base : %p comp ring base : %p data ring base : %p.",
108-
txq->cmd_ring.base, txq->comp_ring.base, txq->data_ring.base);
109-
PMD_TX_LOG(DEBUG, "TXQ: cmd basePA : 0x%lx comp ring basePA : 0x%lx data ring basePA : 0x%lx.",
110-
(unsigned long)txq->cmd_ring.basePA,
111-
(unsigned long)txq->comp_ring.basePA,
112-
(unsigned long)txq->data_ring.basePA);
113-
114-
avail = vmxnet3_cmd_ring_desc_avail(&txq->cmd_ring);
115-
PMD_TX_LOG(DEBUG, "TXQ: size=%u; free=%u; next2proc=%u; queued=%u",
116-
(uint32_t)txq->cmd_ring.size, avail,
117-
txq->comp_ring.next2proc, txq->cmd_ring.size - avail);
118-
}
119-
#endif
12062

12163
static void
12264
vmxnet3_tx_cmd_ring_release_mbufs(vmxnet3_cmd_ring_t *ring)

0 commit comments

Comments
 (0)