Fix Book Library bugs

Author: shafiekwalker7861

debugging/book-library/script.js

@@ -1,22 +1,28 @@
 let myLibrary = [];
 
-window.addEventListener("load", function (e) {
+window.addEventListener("load", function () {
   populateStorage();
   render();
 });
 
 function populateStorage() {
-  if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
-    let book2 = new Book(
+  if (myLibrary.length === 0) {
+    const book1 = new Book(
+      "Robinson Crusoe",
+      "Daniel Defoe",
+      "252",
+      true
+    );
+
+    const book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
       "127",
       true
     );
+
     myLibrary.push(book1);
     myLibrary.push(book2);
-    render();
   }
 }
 
@@ -25,22 +31,34 @@ const author = document.getElementById("author");
 const pages = document.getElementById("pages");
 const check = document.getElementById("check");
 
-//check the right input from forms and if its ok -> add the new book (object in array)
-//via Book function and start render function
 function submit() {
   if (
-    title.value == null ||
-    title.value == "" ||
-    pages.value == null ||
-    pages.value == ""
+    title.value.trim() === "" ||
+    author.value.trim() === "" ||
+    pages.value.trim() === ""
   ) {
     alert("Please fill all fields!");
     return false;
-  } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
-    render();
   }
+
+  const book = new Book(
+    title.value.trim(),
+    author.value.trim(),
+    pages.value,
+    check.checked
+  );
+
+  myLibrary.push(book);
+
+  render();
+
+  // Clear the form after adding a book
+  title.value = "";
+  author.value = "";
+  pages.value = "";
+  check.checked = false;
+
+  return true;
 }
 
 function Book(title, author, pages, check) {
@@ -51,53 +69,58 @@ function Book(title, author, pages, check) {
 }
 
 function render() {
-  let table = document.getElementById("display");
-  let rowsNumber = table.rows.length;
-  //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
+  const table = document.getElementById("display");
+  const rowsNumber = table.rows.length;
+
+  // Remove old book rows but keep the heading row
+  for (let n = rowsNumber - 1; n > 0; n--) {
     table.deleteRow(n);
   }
-  //insert updated row and cells
-  let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
-    let titleCell = row.insertCell(0);
-    let authorCell = row.insertCell(1);
-    let pagesCell = row.insertCell(2);
-    let wasReadCell = row.insertCell(3);
-    let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[i].title;
-    authorCell.innerHTML = myLibrary[i].author;
-    pagesCell.innerHTML = myLibrary[i].pages;
-
-    //add and wait for action for read/unread button
-    let changeBut = document.createElement("button");
-    changeBut.id = i;
-    changeBut.className = "btn btn-success";
-    wasReadCell.appendChild(changeBut);
-    let readStatus = "";
-    if (myLibrary[i].check == false) {
-      readStatus = "Yes";
-    } else {
-      readStatus = "No";
-    }
-    changeBut.innerText = readStatus;
-
-    changeBut.addEventListener("click", function () {
+
+  for (let i = 0; i < myLibrary.length; i++) {
+    const row = table.insertRow(-1);
+
+    const titleCell = row.insertCell(0);
+    const authorCell = row.insertCell(1);
+    const pagesCell = row.insertCell(2);
+    const wasReadCell = row.insertCell(3);
+    const deleteCell = row.insertCell(4);
+
+    titleCell.textContent = myLibrary[i].title;
+    authorCell.textContent = myLibrary[i].author;
+    pagesCell.textContent = myLibrary[i].pages;
+
+    // Read / unread button
+    const changeButton = document.createElement("button");
+
+    changeButton.className = "btn btn-success";
+
+    changeButton.textContent = myLibrary[i].check
+      ? "Yes"
+      : "No";
+
+    changeButton.addEventListener("click", function () {
       myLibrary[i].check = !myLibrary[i].check;
       render();
     });
 
-    //add delete button to every row and render again
-    let delButton = document.createElement("button");
-    delBut.id = i + 5;
-    deleteCell.appendChild(delBut);
-    delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
-      alert(`You've deleted title: ${myLibrary[i].title}`);
+    wasReadCell.appendChild(changeButton);
+
+    // Delete button
+    const deleteButton = document.createElement("button");
+
+    deleteButton.className = "btn btn-warning";
+    deleteButton.textContent = "Delete";
+
+    deleteButton.addEventListener("click", function () {
+      alert(
+        `You've deleted title: ${myLibrary[i].title}`
+      );
+
       myLibrary.splice(i, 1);
       render();
     });
+
+    deleteCell.appendChild(deleteButton);
   }
-}
+}